Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #4825] Deprecate Webhook function of EventMesh Runtime(v1) #5153

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

Pil0tXia
Copy link
Member

Fixes #4825

Motivation

Please see #4825. This PR is the final step to complete the issue, which contains a detailed historical background and a thorough analysis of the pros and cons. It has also been acknowledged in past bi-weekly meetings.

Modifications

Remove webhook processors/handlers in EventMesh runtime server, except GrpcType.WEBHOOK, because it is not related to the feature mentioned in this issue.

Documentation

  • Does this pull request introduce a new feature? (yes)
  • If yes, how is the feature documented? (docs)
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation: Yes, it should be included in the release note of next release, and the doc on the doc site should be removed.

@Pil0tXia Pil0tXia requested a review from xwm1992 December 31, 2024 14:50
@Pil0tXia Pil0tXia requested review from qqeasonchen and mxsm January 2, 2025 09:21
Copy link
Member

@mxsm mxsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mxsm mxsm merged commit ef16253 into apache:master Jan 7, 2025
10 checks passed
@Pil0tXia Pil0tXia deleted the pil0txia/feat_4825 branch January 7, 2025 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Unify HTTP Source Connector and eventmesh-webhook module
3 participants